Add inline padding to FAQ gridline variant - #1441
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 5643700 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🟢 No design token changes found |
There was a problem hiding this comment.
Pull request overview
Updates the FAQ component’s gridline variant styling to add inline padding on narrower viewports, aligning the component’s content spacing for mobile and tablet while keeping desktop unchanged.
Changes:
- Added
padding-inlineto gridline variant wrappers for mobile (--base-size-20). - Adjusted gridline variant padding at tablet breakpoint (
min-width: 48rem) to--base-size-36, and reset to0at desktop (min-width: 63.25rem). - Added a changeset documenting the patch update for
@primer/react-brand.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/FAQ/FAQ.module.css | Adds responsive inline padding for the FAQ gridline variant wrappers (mobile/tablet) and resets at desktop. |
| .changeset/wide-faq-gridlines.md | Records the change as a patch release for @primer/react-brand. |
Review details
Tip
Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
Contributor
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
Contributor
🟢 Bundle size report
|
Contributor
🟢 No unit test coverage changes foundAll components and hooks with tests maintain the same coverage as the main branch. |
Merged
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Towards https://github.com/github/marketing-engineering/issues/6047
Adds inline padding to FAQ where
variant="gridline". Only applies to mobile and tablet.🔗 Preview
List of notable changes:
What should reviewers focus on?
Steps to test:
Supporting resources (related issues, external links, etc):
Contributor checklist:
update snapshotslabel to the PR)Reviewer checklist:
Screenshots: